Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up for example scripts and macro_params.py, pass macro data date ranges, #71

Merged
merged 15 commits into from
Aug 5, 2024
Merged

Clean up for example scripts and macro_params.py, pass macro data date ranges, #71

merged 15 commits into from
Aug 5, 2024

Conversation

jdebacker
Copy link
Collaborator

This PR makes the following enhancements:

  1. Clean up of the run scripts (all output files, including plots and CSV file, saved to a common directory, style file imported from package, more in line comments)
  2. Include two new kwargs in the Calibrate class object which represent the date ranges for macro data. Update the get_macro_params function to take these arguments.
  3. Clean up of calibrate.py: take out references to estimating $\chi^n$ and tax functions, neither of which are used due limited data (at the moment)
  4. Reorganize macro_params.py to better organized calls to different data sources
  5. As a work around for the World Bank WDI API not responding 100% of the time, create try/except workaround.

@jdebacker jdebacker changed the title Clean up for example scripts and macro params, pass macro data date ranges, Clean up for example scripts and macro_params.py, pass macro data date ranges, Aug 2, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.94737% with 8 lines in your changes missing coverage. Please review.

Project coverage is 56.40%. Comparing base (516df70) to head (fce9545).

Files Patch % Lines
ogzaf/macro_params.py 87.50% 3 Missing ⚠️
ogzaf/utils.py 62.50% 3 Missing ⚠️
ogzaf/calibrate.py 50.00% 1 Missing ⚠️
ogzaf/input_output.py 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   55.07%   56.40%   +1.33%     
==========================================
  Files          12       12              
  Lines         345      367      +22     
==========================================
+ Hits          190      207      +17     
- Misses        155      160       +5
Flag Coverage Δ
unittests 56.40% <78.94%> (+1.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdebacker jdebacker marked this pull request as ready for review August 3, 2024 21:42
This was linked to issues Aug 3, 2024
Some South African references for OG-ZAF calibration to consider & Data automation opportunity #65
Closed
WB API failures #67
Closed
@rickecon
Copy link
Collaborator

rickecon commented Aug 3, 2024

@jdebacker. This looks great. Thanks for this. Merging as soon as tests pass.

@rickecon rickecon merged commit 6e576ae into EAPD-DRB:main Aug 5, 2024
9 checks passed
@jdebacker jdebacker mentioned this pull request Aug 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickecon rickecon rickecon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jdebacker @rickecon